Empty values (null, undefined) in 'contains' method

[CoonJS]

I use odata-builder for building large filter from table columns.
Each value can be empty string or undefined value and i want to skip 'contains' operator if value === undefined.

For example:

const filter = {
  name: 'MyName',
  age: undefined  // init value
};

f.build('and').contains('name', filter.name).contains('age', filter.age).toString(); 
// (contains(name, 'MyName')) and (contains(age));

I need to skip contains(age) operator because age === undefined, how to solve this problem?

[bodia-uz]

Hi.

Example 1:
https://jsbin.com/zudajiw/edit?html,js,console

var filter = f();

var filterProps = {
  name: 'MyName',
  age: undefined  // init value
}

Object
  .keys(filterProps)
  .forEach((key) => {
  if (typeof filterProps[key] !== 'undefined') {
    filter.contains(key, filterProps[key]);
  }
});

console.log('$filter=', filter.toString());

Example 2:
https://jsbin.com/jemases/edit?html,js,console

var filter = f();

var filterProps = {
  name: 'MyName',
  age: undefined  // init value
}

function safeContains(filterBuilder, key, value) {
  if (typeof value !== 'undefined') {
    filterBuilder.contains(key, value);
  }
}

safeContains(filter, 'name', filterProps.name);
safeContains(filter, 'age', filterProps.age);

console.log('$filter=', filter.toString());

[CoonJS]

This solution solve my problem, thanks! But you didn't think about encapsulation of this solution in your lib?

[bodia-uz]

Not sure if the silent skip is better. Need to think what to do with it.