Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the Singular template #20

Closed
bobbingwide opened this issue Aug 7, 2021 · 3 comments
Closed

Complete the Singular template #20

bobbingwide opened this issue Aug 7, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

Issue #1 was the first issue for the SB theme, focussing on creating the home page ( index.html )
The Singular template also needs creating:

Requirements

  • Same header, menu, sidebar and footer as the home page
  • Main body to contain:
  • Post title
  • Featured image
  • Post content
  • Seen before
  • Tags for category, S-word and B-word
  • postmeta data
  • post author
  • And, if Jetpack is enabled, the share buttons for Pinterest, Twitter and Facebook - somewhere after the post content.

Proposed solution

  • as above
@bobbingwide
Copy link
Owner Author

bobbingwide commented Aug 7, 2021

For the tags we either need to hide the post terms separators, or override the post-terms block.

<span class="wp-block-post-terms__separator">, </span>

We don't want the commas.

This can be achieved using the separator attribute. This is another attribute that's not supported in the block editor.

@bobbingwide
Copy link
Owner Author

The featured image on the Seriously Bonkers page is the cropped one, not the wide format one.
Is this due to a change in Gutenberg which now assumes the featured image is going to be the post-thumbnail size?
In genesis-SB the post thumbnail size was set in functions.php

set_post_thumbnail_size( 400, 400, true );

@bobbingwide
Copy link
Owner Author

Delivered in SB v0.2.1. There's also a custom singular template called singular-one-column.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant