feat: enable FirstSunset on mainnet #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1016 +/- ##
=======================================
Coverage 47.85% 47.85%
=======================================
Files 127 127
Lines 12822 12822
=======================================
Hits 6136 6136
Misses 6252 6252
Partials 434 434 ☔ View full report in Codecov by Sentry. |
unclezoro
approved these changes
Apr 1, 2024
unclezoro
requested changes
Apr 1, 2024
forcodedancing
approved these changes
Apr 1, 2024
unclezoro
approved these changes
Apr 1, 2024
مرحبا .. كيف يمكنني هذا ...؟ BNB CHAIN Staking Staking Validators 36/55 Bonded Tokens 22,692,254.5076 BNB Guide • BNB Beacon Chain Staking Guides • Staking With Ledger Hardware |
|
كيفية سحب هذا لرصيد bnb .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the FirstSunset height to mainnet config.
Rationale
The target fork time is
2024/4/15/ 06:00:00 UTC+0(1713160800)Current Block time:
2024/4/1 03:25:38 UTC+0(1711941938) -> https://explorer.bnbchain.org/block/372822440Avg Block Time: 19s/11 ~= 1.73s
Target Fork Block Height: (1713160800 - 1711941938)/1.73 + 372822440 ~=
373526985Example
n/a
Changes
Notable changes:
n/a
Preflight checks
make build)make test)make integration_test)Already reviewed by
n/a
Related issues
n/a