Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condense download graded paper buttons #804

Open
srisainachuri opened this issue Feb 25, 2022 · 1 comment
Open

Condense download graded paper buttons #804

srisainachuri opened this issue Feb 25, 2022 · 1 comment
Labels
frontend starter

Comments

@srisainachuri
Copy link
Contributor

LGTM. Not tested on stage.

Lots of reused code segments makes me think we can shove some parts of this into a react component on its own and pass the paper object and graded_files[paper.id] into the component.

Also I wonder what JS code convention is between the repeated gradedHrefData ? and a giant if {} block.

Originally posted by @erwang01 in #803 (review)
@srisainachuri
Copy link
Contributor Author

Main Code pointers:
PaperGradeTable.js
PaperSubmissionTable.js
AdvisorPaperView.js

Condense the Download Paper menus in all of these into a single component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend starter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srisainachuri