-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file upload bug in DelegatePaperView #764
Comments
We can consider moving history.redirect to inside the upload callback function. huxley/huxley/www/js/components/DelegatePaperView.js Lines 220 to 222 in da7a189
This way we only redirect upon success. However #785 is probably a better way of doing things. |
Moving the history.redirect works! #785 is probably cleaner, currently looking into why the existing listener doesn't suffice. |
_handleSuccess doesn't seem to change the state at all. Try moving this into _handleSuccess? huxley/huxley/www/js/components/DelegatePaperView.js Lines 212 to 214 in da7a189
I'm not entirely sure what the purpose of resetting this state is but I guess it lets the user upload a new file if they want to change it? Also what does a listener do again? |
For some files, especially larger ones, uploading position papers will error and not successfully upload. Most likely cause of issue is history.redirect refreshes the page before the upload actually finishes.
Code pointers:
DelegatePaperView.js
The text was updated successfully, but these errors were encountered: