Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all html anchors to Button components #763

Open
mathildepm opened this issue Jul 15, 2021 · 0 comments · May be fixed by #774
Open

Change all html anchors to Button components #763

mathildepm opened this issue Jul 15, 2021 · 0 comments · May be fixed by #774
Assignees

Comments

@mathildepm
Copy link
Contributor

mathildepm commented Jul 15, 2021

One of the benefits of using react is that it allows us to have cleaner code by using what are called components. You can think of components like an object on the page. It has certain "props", which are variables that you need to pass in in order for it to render. Components help modularize the code and keep consistent styling.

We have a Button component that is useful for, as you can imagine, making buttons. However, in some places in the code, people have used HTML anchors instead of buttons. Your job is to replace those HTML anchors with Button components that do the same thing.

Anchors will look like <a href={something} label={something}> and you should change this to <Button href{something} label={something} />. You may have to look at the props in Button.js to rearrange some of the values for styling (it won't just be copy paste). You will also have to import Button in the relevant file. You can take a look at how we import button in ChairNoteView.js

Code pointers:
Button.js
AdvisorPaperView.js
PaperGradeTable
PaperSubmissionTable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants