Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize ChairNoteView and DelegateNoteView #738

Open
shaynak opened this issue Feb 25, 2021 · 0 comments
Open

Modularize ChairNoteView and DelegateNoteView #738

shaynak opened this issue Feb 25, 2021 · 0 comments

Comments

@shaynak
Copy link
Member

shaynak commented Feb 25, 2021

ChairNoteView and DelegateNoteView contain a lot of similar logic -- they're both almost the same component, just using slightly different information to determine who to send things to. This also means that any changes to the Notes views can require modification of two files, which is not ideal.

We should create a component called NoteView that both ChairNoteView and DelegateNoteView display on render. One way to implement this would be to take in an additional prop called is_chair, and to use some blocks of code if is_chair is true and some blocks of code if it is false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant