Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No duplicate emails vs. remove email login #654

Open
m-j-mcdonald opened this issue Feb 4, 2018 · 2 comments
Open

No duplicate emails vs. remove email login #654

m-j-mcdonald opened this issue Feb 4, 2018 · 2 comments

Comments

@m-j-mcdonald
Copy link
Contributor

Right now there's an issue with email login when two users have the same email, because clearly it can't resolve which user to login as. This throws an uncaught exception in the python code and hangs the process. This is mainly when an advisor and delegate share the same email. So the options are to either disable email login entirely or disallow conflicting emails. The first option doesn't seem bad, since it's not unreasonable for people to actually remember their usernames and they can always use forgot password to get the user name. The second is probably the better approach though, at the cost of annoying a few people who want to use the same email in multiple places.

@tdowds
Copy link
Contributor

tdowds commented Jan 1, 2019

Can you elaborate a bit more on what the advisor was trying to do that caused this to happen? For example, was the advisor trying to log in to his delegates' accounts to submit papers on their behalf? Was the advisor also a delegate trying to log in to his delegate account to submit a paper? Is it something different altogether? A mix of both?

Also, how large of an issue is this? Was this one advisor that brought this to your attention, or multiple advisors who were facing this issue?

@m-j-mcdonald
Copy link
Contributor Author

The issue was a delegate would register the advisor account using their own email, and then also register their delegate account with the same email. Then they couldn’t login to either using their email (using the username was fine though). It happened around five times if I recall correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants