Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delegate feedback state from Delegate model #580

Open
tdowds opened this issue Mar 19, 2017 · 2 comments
Open

Remove delegate feedback state from Delegate model #580

tdowds opened this issue Mar 19, 2017 · 2 comments
Assignees
@jmosky12 @m-j-mcdonald @jaketibbetts
Labels
api refactor

Comments

@tdowds
Copy link
Contributor

tdowds commented Mar 19, 2017

Given @kmeht's comments in this pr, we should rethink how we're storing our feedback data.
@m-j-mcdonald m-j-mcdonald mentioned this issue Aug 1, 2017
Merged
@tdowds
Copy link
Contributor Author

tdowds commented Sep 7, 2017

Don't know where you guys are at with this, but might not be a bad idea to post here whatever designs you have in mind for storing this information before hopping into the code.

@m-j-mcdonald
Copy link
Contributor

I've been working with Jake & Jake on how to structure it. It's going to create a feedback model that will belong to an assignment (assignments will have a one-to-one field with it). The alternative was having the feedback model have an assignment but there weren't any strong advantages to that and this seemed more intuitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmosky12 jmosky12

@m-j-mcdonald m-j-mcdonald

@jaketibbetts jaketibbetts

Labels
api refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kmeht @tdowds @jmosky12 @m-j-mcdonald @jaketibbetts