Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design a way to programmatically bootstrap all constants on page load. #209

Open
kmeht opened this issue Jun 17, 2014 · 1 comment
Open

Design a way to programmatically bootstrap all constants on page load. #209

kmeht opened this issue Jun 17, 2014 · 1 comment
Assignees
@kmeht
Labels
code cleanup refactor
Milestone
Continuing Improv...

Comments

@kmeht
Copy link
Member

kmeht commented Jun 17, 2014

There are two problems with the way we currently bootstrap constants (e.g. ContactTypes and GenderConstants):

  1. We bootstrap lazily, i.e. the constants data is in the global namespace until the module is first loaded. This means a user could potentially change the data to something malicious before bootstrapping. We should bootstrap all of our data on page load.
  2. It's already evident that there will be a lot of boilerplate. ContactTypes and GenderConstants are actually identical. Let's determine a programatic way of doing this.
@kmeht kmeht added this to the MVP milestone Jun 17, 2014
@kmeht kmeht self-assigned this Jun 24, 2014
@kmeht
Copy link
Member Author

kmeht commented Aug 29, 2014

Punting to later, not necessarily required for MVP.

@kmeht kmeht added the refactor label Aug 29, 2014
@kmeht kmeht modified the milestones: Continuing Improvements, MVP Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmeht kmeht

Labels
code cleanup refactor
Projects
None yet
Milestone
Continuing Improvements
Development

No branches or pull requests
1 participant
@kmeht