Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't compile #2

Open
0x6e6562 opened this issue Mar 5, 2014 · 2 comments
Open

Tests don't compile #2

0x6e6562 opened this issue Mar 5, 2014 · 2 comments

Comments

@0x6e6562
Copy link
Contributor

0x6e6562 commented Mar 5, 2014

I'm not sure whether the Go standard library has changed since this library was written, but I seem to get the following compile errors for the test suite:

➜  csvutil git:(master) go version
go version go1.2 darwin/amd64
➜  csvutil git:(master) go test -v
# _/Users/0x6e6562/Workspace/golang/src/github.com/bmatsuo/csvutil
./config_test.go:31: undefined: utf8.NewString
./file_test.go:17: undefined: os.ENOENT
./file_test.go:21: statErr.String undefined (type error has no field or method String)
./file_test.go:25: rmErr.String undefined (type error has no field or method String)
./file_test.go:40: cannot use TestPerm (type uint32) as type os.FileMode in function argument
./file_test.go:65: cannot use TestPerm (type uint32) as type os.FileMode in function argument
./file_test.go:71: err.String undefined (type error has no field or method String)
./reader_test.go:86: err.String undefined (type error has no field or method String)
./writer_test.go:21: err.String undefined (type error has no field or method String)
FAIL    _/Users/0x6e6562/Workspace/golang/src/github.com/bmatsuo/csvutil [build failed]
@bmatsuo1
Copy link

bmatsuo1 commented Mar 5, 2014

Ah. Yes. This is due to some changes in the standard library long ago. This package needs some love. But I have a new project that could make use of this. So I'll put in some time this week to bring it up to snuff.

Thanks for bringing this to my attention.

@0x6e6562
Copy link
Contributor Author

0x6e6562 commented Mar 5, 2014

Thanks for the heads up - it's good to see that you'll re-live this project :-)

Right now I have a problem that this library solves to about 80% - what is missing is date parsing and being able to handle null fields. So if this is brought into a maintained state, I'd consider going ahead with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants