Pyright #252
Pyright #252
Conversation
.devcontainer/devcontainer.json
Outdated
There was a problem hiding this comment.
These are intentional, so we get reasonable settings without a .vscode dir
There was a problem hiding this comment.
noted. I feel like was set up to fail on this task!
catalog-info.yaml
Outdated
There was a problem hiding this comment.
This should also be deleted
| from bluesky.callbacks.best_effort import BestEffortCallback | ||
| from bluesky.plan_stubs import mov, movr, rd # noqa | ||
| from bluesky.plans import grid_scan # noqa | ||
| from bluesky.run_engine import RunEngine |
There was a problem hiding this comment.
Curious why these imports changed?
There was a problem hiding this comment.
Here I was just doing what pyright asked me to - It seemed that it did not like the module level declaration in init.py.
| @@ -170,20 +170,20 @@ async def test_mover_disconncted(): | |||
| with pytest.raises(NotConnected): | |||
| async with DeviceCollector(timeout=0.1): | |||
| m = demo.Mover("ca://PRE:", name="mover") | |||
| assert m.name == "mover" | |||
| assert m.name == "mover" | |||
There was a problem hiding this comment.
These should be in their original position
There was a problem hiding this comment.
pyright did not like that. it said that m may not be instantiated.
Looking at it again I see that this is not going to behave as required with my change (because the expected exception would jump over final assert)
pyright is correct in that if the DeviceCollector constructor throws NotConnected then m would not be set.
But this is rather pedantic and should probably be ignored.
There was a problem hiding this comment.
or pre declare m.
OK lets do this. But you realize 30 mins is less than 18 seconds per issue? |
This PR re-adopts the copier, making sure that pyproject.toml is correct for pyright adoption.
It also has started to fix pyright errors in the source. BUT there seem to be many errors in here that someone with a better understanding of the code should look at.
type: ignoreto everything at 5PM on Friday and I also don't think that is the right way to go.@coretl I'll let you decide what to do with this branch, I'm OK to carry on with it next week but imagine it is a few days work to do right.