Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SignalRW helpers #221

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add SignalRW helpers #221

merged 1 commit into from
Apr 19, 2024

Conversation

GDYendell
Copy link
Contributor

Fixes #139

coretl
coretl requested changes Apr 17, 2024
View reviewed changes
src/ophyd_async/epics/signal/signal.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/signal/signal.py Outdated Show resolved Hide resolved
@GDYendell GDYendell force-pushed the signal-rw-rbv branch 2 times, most recently from 5fa019d to f3e817b Compare April 18, 2024 09:37
coretl
coretl reviewed Apr 18, 2024
View reviewed changes
tests/core/test_signal.py Outdated Show resolved Hide resolved
@GDYendell
Add epics_signal_rw_rbv helper function
eb1e604 
Add tests for all signal creation helpers
@coretl coretl merged commit f294582 into main Apr 19, 2024
18 checks passed
@coretl coretl deleted the signal-rw-rbv branch April 19, 2024 07:56
@DominicOram
Copy link
Contributor

Does it make sense to update the signals in AD with this e.g.

ophyd-async/src/ophyd_async/epics/areadetector/utils.py

Line 11 in c42afcb

return epics_signal_rw(datatype, prefix + "_RBV", prefix)
?

@DominicOram DominicOram mentioned this pull request Apr 19, 2024
Open
gilesknap pushed a commit to gilesknap/ophyd-async that referenced this pull request Apr 19, 2024
@GDYendell @gilesknap
Add epics_signal_rw_rbv helper function (bluesky#221)
e4396ea 
Add tests for all signal creation helpers
@coretl coretl mentioned this pull request Apr 19, 2024
Closed
@DominicOram DominicOram mentioned this pull request Apr 26, 2024
Closed
@GDYendell GDYendell mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumforrester callumforrester callumforrester left review comments

@coretl coretl coretl approved these changes

@DominicOram DominicOram Awaiting requested review from DominicOram

@olliesilvester olliesilvester Awaiting requested review from olliesilvester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make _RBV helper externally visible
5 participants
@GDYendell @DominicOram @callumforrester @coretl @olliesilvester