Update Pilatus Controller, Driver to match development of ADAravis, TetrAMM #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DiamondJoseph
commented
Apr 11, 2024
•
DiamondJoseph
commented
- Name all device-specific Enums consistently with the name of the device
- Make controller driver access private, able to access from StandardDetector implementation (required on Detector as is a child Device and must have connect() called
- Set exposure time
- Do not allow overriding known GOOD_STATES
- Except in consistent way when non-supported TriggerMode
- Allow driver to be named
DiamondJoseph
changed the title
2 tasks
coretl
approved these changes
Apr 15, 2024
callumforrester
approved these changes
Apr 18, 2024
OCopping
pushed a commit
that referenced
this pull request
Apr 18, 2024
…etrAMM (#191) * Update PilatusDriver, Controller to match Aravis patterns * Add facility generic PilatusDetector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.