-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ai/ao records with prec=0 as Signal[int] #280
Comments
Once the following are merged we can drop the changes introduced in #276 PandABlocks/PandABlocks-ioc#112 We've decided these kind of checks shouldn't be handled in ophyd-async - pandablocks-ioc should be using an int for the record if ophyd-async expects an int datatype. |
int
datatypes for float
PVs only if PREC
is 0
This has since come up with the CA backend, so I think we need to support this anyway. I suggest we:
|
@evalott100 are you doing this? Otherwise MX-DAQ would be happy to pick up |
That would be much appreciated, there are a few tickets I'll be doing in this sprint before I get round to this one. |
In #276, we fixed the bug that the panda intialises an analogOut with precision 0 as an int. The signal is made (correctly) with an
int
, howevermake_converter
failsophyd-async/src/ophyd_async/epics/_backend/_p4p.py
Lines 219 to 220 in 58e1cf4
since
float
is not a subclass ofint
.The fix in in #276 allows the signal to be made anyway. We should add the constraint that
.PREC == 0
.The text was updated successfully, but these errors were encountered: