You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The functionality of RunRouter's filling is confusing. By default, it tries to fill and silently gives up if it encounters a spec it doesn't know. You can opt in to stricter behavior. So far, so good.
By default (False), if a document with a spec not in
``handler_registry`` is encountered, let it pass through unfilled. But
if set to True, fill everything and `raise
``UndefinedAssetSpecification`` if some unknown spec is encountered.
But when it fails to resolve a spec, it bails on filling the entire document. That is, if an Event has fields from two detectors, and we know how to fill Detector A but we don't know how to fill Detector B, neither will be filled.
I haven't given thought yet to what we should do about this, just making sure it is documented.
The functionality of
RunRouter
's filling is confusing. By default, it tries to fill and silently gives up if it encounters aspec
it doesn't know. You can opt in to stricter behavior. So far, so good.event-model/event_model/__init__.py
Lines 1223 to 1227 in 14b0826
But when it fails to resolve a
spec
, it bails on filling the entire document. That is, if an Event has fields from two detectors, and we know how to fill Detector A but we don't know how to fill Detector B, neither will be filled.I haven't given thought yet to what we should do about this, just making sure it is documented.
event-model/event_model/__init__.py
Lines 1342 to 1349 in 14b0826
The text was updated successfully, but these errors were encountered: