Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more robust to admission webhook issues #14

Open
joel-bluedata opened this issue Oct 2, 2018 · 1 comment
Open

be more robust to admission webhook issues #14

joel-bluedata opened this issue Oct 2, 2018 · 1 comment

Comments

@joel-bluedata
Copy link
Member

If the mutating admission controller is not enabled on K8s (cf. issue #2), our webhook will just silently never get called for anything. This breaks some of our admission control which leads to unexpected consequences. One obvious bad thing is that code that assumes a non-nil number of role members will crash, but there are other bad things.

I don't think we should even try to make the reconciliation code robust against the possibility of broken admission control. Instead, at startup time KD needs to probe whether the validator is working (send a request to it and make sure the request is received) and shut down if the validator is broken.

@joel-bluedata
Copy link
Member Author

Possibly related to issue #111.

kmathur2 pushed a commit that referenced this issue Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant