Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading widget is not shown when the imageProvider changed[BUG] #507

Open
khhily opened this issue Apr 8, 2022 · 0 comments · May be fixed by #508
Open

Loading widget is not shown when the imageProvider changed[BUG] #507

khhily opened this issue Apr 8, 2022 · 0 comments · May be fixed by #508
Labels
bug Something isn't working

Comments

@khhily
Copy link

khhily commented Apr 8, 2022

I use photo_view version 0.12.0.
I have two imageProvider, and I need to change them via a button in the page to show by the widget PhotoViewGallery. They download images and show correctly.
But there's a little problem, the loading widget only show when the first imageProvider loading, when I change the imageProvider, the loading widget not show when imageProvider loading, and image will show correctly when imageProvider load complete.

My flutter version is 2.2.3

I found that when imageProvider changed in ImageWrapper, you only change the listener of imageProvider's ImageStream, but is not set the _loading to true, so the loadingWidget do not show.

@khhily khhily added the bug Something isn't working label Apr 8, 2022
khhily added a commit to khhily/photo_view that referenced this issue Apr 9, 2022
@khhily khhily linked a pull request Apr 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant