feat: ExoPlayer for Android #1526
Assignees
Labels
Comments
fzyzcjy
changed the title
|
I already started a new branch: But as some features are not available, I thought about using a completely new module like |
|
@Gustl22 Oh that's great! Looking forward to that! |
|
@Gustl22 So... Does it work now, or is there any problems? |
|
@fzyzcjy it's not really functional (only experimental), and I also propose a new module, which does not mess around with the "old" android code. So it may be better to restart from the beginning. |
|
@Gustl22 I see :) |
2 tasks
8 tasks
Gustl22
added a commit
that referenced
this issue
Sep 7, 2023
# Description The tests in Windows & Android are possibly flaky for this reason: - In general it is not tested, if a source starts to play for app tests. - In the app test for `ReleaseMode.loop`, the source starts to play, but never completes or stops. See: https://github.com/bluefireteam/audioplayers/blob/fe81f3b1e600fe005febbe7cd3da02735a3de004/packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart#L104 . This is now checked by getting the current position. The solution to the problem also raises another issue on Android, as the position can not be retrieved on very short sources, thus they are excluded from these tests and it is expected to make it work with Exoplayer (#1526).
2 tasks
Gustl22
added a commit
that referenced
this issue
Sep 26, 2023
# Description The tests in Windows & Android are possibly flaky for this reason: - In general it is not tested, if a source starts to play for app tests. - In the app test for `ReleaseMode.loop`, the source starts to play, but never completes or stops. See: https://github.com/bluefireteam/audioplayers/blob/fe81f3b1e600fe005febbe7cd3da02735a3de004/packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart#L104 . This is now checked by getting the current position. The solution to the problem also raises another issue on Android, as the position can not be retrieved on very short sources, thus they are excluded from these tests and it is expected to make it work with Exoplayer (#1526). (cherry picked from commit c5b0b6e)
Gustl22
changed the title
This was referenced Oct 26, 2023
7 tasks
Closed
Gustl22
added a commit
that referenced
this issue
Nov 14, 2023
# Description The tests in Windows & Android are possibly flaky for this reason: - In general it is not tested, if a source starts to play for app tests. - In the app test for `ReleaseMode.loop`, the source starts to play, but never completes or stops. See: https://github.com/bluefireteam/audioplayers/blob/fe81f3b1e600fe005febbe7cd3da02735a3de004/packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart#L104 . This is now checked by getting the current position. The solution to the problem also raises another issue on Android, as the position can not be retrieved on very short sources, thus they are excluded from these tests and it is expected to make it work with Exoplayer (#1526).
This was referenced Nov 15, 2023
This was referenced Nov 20, 2023
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
It seems that many people prefer ExoPlayer than AudioPlayer (eg. https://www.reddit.com/r/androiddev/comments/95l3hc, and searching demo apps in Github for Android + audio). ExoPlayer also seems to have a lot of pros (see https://developer.android.com/guide/topics/media/exoplayer/pros-and-cons), and is an official android thing.
Therefore, shall we switch to ExoPlayer?
The text was updated successfully, but these errors were encountered: