Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filecoin native addresses #2195

Closed
fedor-ivn opened this issue Aug 26, 2024 · 3 comments · Fixed by #2248
Closed

Filecoin native addresses #2195

fedor-ivn opened this issue Aug 26, 2024 · 3 comments · Fixed by #2248
Assignees
Labels
v1.36.0 Release v1.36.0

Comments

@fedor-ivn
Copy link

fedor-ivn commented Aug 26, 2024

After blockscout/blockscout#10468 lands, API endpoints that render address objects will include Filecoin’s native addressing format. Please refer to the PR description for details on the updated API response format.

API

Here are some of the examples of addresses indexed by filecoin.blockscout.com:

I can provide more examples by request.

Requested Customizations

General UI Updates

The Filecoin community prefers native Filecoin addresses over Ethereum 0x-style addresses. For example, use f3uc2czji2lq5v2mii2brulqsf2x7ndbwbewziulvx4y4fgk2cc3t7qrnzef56embyqxsuzfkf2kkauopggcsa (Filecoin native address) instead of 0xfF000000000000000000000000000000003053b4 (0x-style address).

All UI components displaying Ethereum 0x-style addresses should be updated to show the Filecoin native address. This change applies to lists, views, and other relevant components.

Address Details Page

In addition to displaying the Filecoin address instead of the Ethereum address (as mentioned above), the address details page should include the following fields:

Field Name Format Tooltip Implementation Notes
ID Text Short identifier of an address that may change with chain state updates. Consider adding a Copy to clipboard button next to this field.
Actor Tag Identifies the purpose and behavior of the address on the Filecoin network. Map API values to human-readable tags as follows:

- account: Account
- cron: Scheduled Tasks
- datacap: Data Cap Management
- eam: Ethereum Address Manager
- ethaccount: Ethereum-Compatible Account
- evm: Ethereum Virtual Machine
- init: Initialization
- market: Storage Market
- miner: Storage Provider
- multisig: Multi-Signature Wallet
- paych: Payment Channel
- placeholder: Placeholder Address
- power: Power Management
- reward: Incentives and Rewards
- system: System Operations
- verifreg: Verification Registry
Ethereum Address Text 0x-style address to which the Filecoin address is assigned by the Ethereum Address Manager Filecoin’s 0x-style addresses fall into two categories:

1. Real Ethereum Addresses: These start with the f410 prefix and map to actual Ethereum addresses. They have an actor_type of evm.
2. Dummy Addresses: These do not map to real Ethereum addresses, starting with 0xff0000000000000000000000, followed by a hex-encoded Filecoin native ID. They have an actor_type other than evm.

Display Ethereum addresses only for the first category.

Consider adding a Copy to clipboard button next to this field.

Layout Example

Current State:

Current State

Updated Layout:

Updated Layout

@isstuev isstuev self-assigned this Sep 16, 2024
@isstuev isstuev added the need API For issues that wait for API changes label Sep 17, 2024
@isstuev
Copy link
Collaborator

isstuev commented Sep 17, 2024

found some additional api endpoints to be updated

@isstuev
Copy link
Collaborator

isstuev commented Oct 14, 2024

@isstuev isstuev removed the need API For issues that wait for API changes label Oct 18, 2024
@isstuev
Copy link
Collaborator

isstuev commented Oct 28, 2024

waiting for robust addresses in proxy implementations array

@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.36.0 Release v1.36.0 labels Nov 4, 2024
@tom2drum tom2drum removed the pre-release Tasks in pre-release right now label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.36.0 Release v1.36.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants