Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WC social login #2159

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enable WC social login #2159

wants to merge 2 commits into from

Conversation

maxaleks
Copy link
Contributor

@maxaleks maxaleks commented Aug 9, 2024

Description and Related Issue(s)

Expected to resolve #2140

I have tested these changes locally and on the demo, but it looks like nothing is working. I was only able to log in through Farcaster (and that with errors). When logging in via other social networks, the loader appears, the window with login to the social network opens, and the loader disappears immediately without waiting for me to log in (and if I finally log in, nothing happens, of course).

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@maxaleks maxaleks requested a review from tom2drum August 9, 2024 12:25
@github-actions github-actions bot added the enhancement New feature or request label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable WC social login
1 participant