Skip to content

Update dependencies #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 11, 2025
Merged

Update dependencies #234

merged 9 commits into from
Mar 11, 2025

Conversation

hacknus
Copy link
Contributor

@hacknus hacknus commented Mar 11, 2025

updated all outdated dependencies.

@hacknus
Copy link
Contributor Author

hacknus commented Mar 11, 2025

.. weird that this fails.. I now put Cargo.lock in .gitignore. I think the lock file should not be committed for crates.

@blitzarx1
Copy link
Collaborator

Hi! Strange that it fails, and I am not sure that we need to gitignore Cargo lock.

Have you tried to build it locally?

I will give it a try later as well

@hacknus
Copy link
Contributor Author

hacknus commented Mar 11, 2025

@blitzarx1 I think lock files should be ignored, as noted in the linked issue above.
It builds fine locally on my mac (macOS 15.3.1 and rustc 1.84.1). No clue why it fails with the runner...

@hacknus
Copy link
Contributor Author

hacknus commented Mar 11, 2025

I'll push some commits to test the runner on my profile, you don't have to approve the workflows here. I'll get back to you.

@hacknus
Copy link
Contributor Author

hacknus commented Mar 11, 2025

Ok fixed it, a feature was missing!

@blitzarx1
Copy link
Collaborator

NIce! Thanks for the contribution 😄

@blitzarx1 blitzarx1 merged commit ab4e56b into blitzar-tech:main Mar 11, 2025
3 checks passed
@flokli
Copy link

flokli commented Mar 12, 2025

I think this also included the changes initially done in #231. Would be nice if you could take a look and let me know if anything is missing from there. Thanks!

@flokli flokli mentioned this pull request Mar 12, 2025
@blitzarx1
Copy link
Collaborator

Looks nice. I think nothing is missing! 🤝

@flokli
Copy link

flokli commented Mar 12, 2025

Ok, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants