Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in fm_get_p function #8

Open
wsgtcyx opened this issue Apr 28, 2019 · 1 comment
Open

error in fm_get_p function #8

wsgtcyx opened this issue Apr 28, 2019 · 1 comment

Comments

@wsgtcyx
Copy link

wsgtcyx commented Apr 28, 2019

Hi, I found that in the 51th line of your fm_parallel_sgd.scala file, the result of "val phi = 0.5*(VX:VX - VX_square).sum" and "val phi = 0.5(VX:*VX :- VX_square).sum" is different, which the second one should be right, described in original paper. please check. Thank you!

@luweiagi
Copy link

Hi, I found that in the 51th line of your fm_parallel_sgd.scala file, the result of "val phi = 0.5*(VX:VX - VX_square).sum" and "val phi = 0.5(VX:*VX :- VX_square).sum" is different, which the second one should be right, described in original paper. please check. Thank you!

I think the author is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants