Please add the 8 lines of code to adobepass.py to support auto-logins from largest ISP in USA

[tv21]

I would refer you to my Apr 23, 2019 comment (the last one on the page as I write this) at ytdl-org#20749 (reposted below in a reply to this post) - I have been waiting for at least a year and a half for this to be added, it is only 8 lines of code and it works. The issue is that if you are an Xfinity customer and you try to use youtube-dl while on your home Xfinity connection (in other words you are not on vacation trying to log in through some other ISP) it will not allow you to login unless it completes its auto-login sequence. This 8 line fix has been around for many months now and works very well but for some reason that makes no sense to me they refuse to add it to the main distribution, so an Xfinity user has to manually patch every new version and then run it from source, which most users would not know how to do, or as often happens just keep running old versions until something breaks. It would be a huge help if you could add this small patch in to your build. By the way this issue affects all services, not just SyFy as the issue title might suggest.

[tv21]

Just in case you can't see it or it goes away for some reason, here is the text of the post I referred to above:

For those running from source code or compiling your own, the quick fix for Comcast Xfinity is to use this version of adobepass.py:

https://raw.githubusercontent.com/bhamboss/youtube-dl/patch-1/youtube_dl/extractor/adobepass.py

That is from https://github.com/bhamboss/youtube-dl/blob/patch-1/youtube_dl/extractor/adobepass.py and I can confirm this works with Xfinity's new login if you are coming in from an Xfinity IP address.

Just to be clear, Xfinity authenticates differently if you are coming in from one of their IP addresses vs. if you are coming in from the IP of some other provider. I tested the above patch coming from an Xfinity IP. I did NOT test it from another provider's IP.

If I run diff -u on the original and patched files I get this:

$ diff -u adobepass.py.original adobepass.py.patched
--- adobepass.py.original	2018-10-17 01:22:56.000000000 -0400
+++ adobepass.py.patched	2019-04-23 08:53:36.000000000 -0400
@@ -1433,6 +1433,14 @@
                             provider_redirect_page, 'oauth redirect')
                         self._download_webpage(
                             oauth_redirect_url, video_id, 'Confirming auto login')
+                    elif 'automatically signed in with' in provider_redirect_page:
+                        # Seems like comcast is rolling up new way of automatically signing customers
+                        oauth_redirect_url = self._html_search_regex(
+                            r'continue:\s*"(https://oauth.xfinity.com/oauth/authorize\?.+)"',
+                            provider_redirect_page, 'oauth redirect (signed)')
+                        # Just need to process the request. No useful data comes back
+                        self._download_webpage(
+                            oauth_redirect_url, video_id, 'Confirming auto login')
                     else:
                         if '<form name="signin"' in provider_redirect_page:
                             provider_login_page_res = provider_redirect_page_res

I will just note that I have been applying this patch to subsequent versions of adobepass.py and it still works.