From ed868dc13d1f2ebb41c1bc23e2dd9bcc2bc101b8 Mon Sep 17 00:00:00 2001 From: Louis Kirkham Date: Fri, 16 Feb 2024 07:16:43 +0000 Subject: [PATCH] Adds target _blank to nomination table links https://app.asana.com/0/1199154381249427/1206580439748047 Opens a new tab for links on the nominations table for admins and assessors --- .../form_answers/list_components/_table_body.html.slim | 6 +++--- app/views/assessor/form_answers/_list_body.html.slim | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/views/admin/form_answers/list_components/_table_body.html.slim b/app/views/admin/form_answers/list_components/_table_body.html.slim index 36498ae91..33e6d19a4 100644 --- a/app/views/admin/form_answers/list_components/_table_body.html.slim +++ b/app/views/admin/form_answers/list_components/_table_body.html.slim @@ -5,10 +5,10 @@ td.govuk-table__cell = check_box_tag "check_#{obj.id}", obj.id, false, class: "form-answer-check", aria: { label: "Select nomination #{obj.id} for bulk action" } td.td-title.govuk-table__cell - if obj.company_or_nominee_name.present? - = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination for #{obj.company_or_nominee_name}" }, class: 'govuk-link' do + = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination for #{obj.company_or_nominee_name}" }, class: 'govuk-link', target: :_blank do = obj.company_or_nominee_name - else - = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination, nominee name not yet specified" }, class: 'govuk-link' do + = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: "View submitted nomination, nominee name not yet specified" }, class: 'govuk-link', target: :_blank do em ' Not yet specified td.govuk-table__cell = obj.dashboard_status @@ -35,5 +35,5 @@ = obj.last_updated_by td.govuk-table__cell - aria_label = obj.company_or_nominee_name.present? ? "View submitted nomination, for #{obj.company_or_nominee_name}" : "View submitted nomination, nominee name not yet specified" - = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link' do + = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link', target: :_blank do | View diff --git a/app/views/assessor/form_answers/_list_body.html.slim b/app/views/assessor/form_answers/_list_body.html.slim index b94448901..5424c68c5 100644 --- a/app/views/assessor/form_answers/_list_body.html.slim +++ b/app/views/assessor/form_answers/_list_body.html.slim @@ -2,7 +2,7 @@ tbody.govuk-table__body - FormAnswerDecorator.decorate_collection(@form_answers).each do |obj| tr.govuk-table__row th.govuk-table__header scope="row" - = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), class: 'govuk-link' do + = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), class: 'govuk-link', target: :_blank do - unless obj.nominee_name.nil? span = obj.nominee_name @@ -33,5 +33,5 @@ tbody.govuk-table__body td.govuk-table__cell - aria_label = obj.company_or_nominee_name.present? ? "View submitted nomination, for #{obj.company_or_nominee_name}" : "View submitted nomination, nominee name not yet specified" - = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link' do + = link_to polymorphic_url([namespace_name, obj], search_id: params[:search_id], year: params[:year]), aria: { label: aria_label }, class: 'govuk-link', target: :_blank do | View