Prepare strings for Android Crowdin sync #3327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vvolkgang I think we should go ahead and replace references to the old |
|
@SaintPatrck I don't have a preference, if you're able to replace resources now without removing existing translations then let's go with that! |
|
No longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
String resources,
ContinueandDefaultuse key values that are protected keywords in Android XML resource files. In order to prepare the MAUI project for syncing with the native Android project these terms must have their keys replaced. To prevent losing translations for the existing keys we are adding matching resources that do not use protected keywords. Once translations have been migrated in Crowdin the legacy entries will be removed.Code changes
ContinueTextandDefaultText.Before you submit
dotnet format --verify-no-changes) (required)