Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timex.shift yields incorrect results for leap year after update #709

Open
rizasal opened this issue Mar 21, 2022 · 1 comment
Open

Timex.shift yields incorrect results for leap year after update #709

rizasal opened this issue Mar 21, 2022 · 1 comment

Comments

@rizasal
Copy link

rizasal commented Mar 21, 2022

Steps to reproduce

  • API function called - Timex.shift
  • Arguments provided - Timex.shift(~D[2020-02-29], years: 1)

Description of issue

  • The same arguments on version 3.6.1 yields the correct result of ~D[2021-02-28] whereas the latest version 3.7.6 yields ~D[2021-03-01]

image
@elielhaouzi
Copy link

elielhaouzi commented Apr 21, 2022 •
edited
Loading

As I see in the test the changes seem to be wanted. The question is why the previous behavior has been changed ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elielhaouzi @rizasal