Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: trino-mongo use deprecated jvm option #36

Closed
wirelessr opened this issue Jan 18, 2024 · 1 comment · Fixed by #44
Closed

Bug: trino-mongo use deprecated jvm option #36

wirelessr opened this issue Jan 18, 2024 · 1 comment · Fixed by #44

Comments

@wirelessr
Copy link

wirelessr commented Jan 18, 2024

trino-mongo-trino-coordinator-1  | + launcher_opts=(--etc-dir /etc/trino)
trino-mongo-trino-coordinator-1  | + grep -s -q node.id /etc/trino/node.properties
trino-mongo-trino-coordinator-1  | + launcher_opts+=("-Dnode.id=${HOSTNAME}")
trino-mongo-trino-coordinator-1  | + exec /usr/lib/trino/bin/launcher run --etc-dir /etc/trino -Dnode.id=trino-coordinator
trino-mongo-trino-coordinator-1  | Unrecognized VM option 'UseBiasedLocking'
trino-mongo-trino-coordinator-1  | Error: Could not create the Java Virtual Machine.
trino-mongo-trino-coordinator-1  | Error: A fatal exception has occurred. Program will exit.
trino-mongo-trino-coordinator-1 exited with code 1

Since the latest trino image doesn't support UseBiasedLocking anymore, this option should be removed.

By the way, the following is the default config for jvm.config in the latest image.

-server
-agentpath:/usr/lib/trino/bin/libjvmkill.so
-XX:InitialRAMPercentage=80
-XX:MaxRAMPercentage=80
-XX:G1HeapRegionSize=32M
-XX:+ExplicitGCInvokesConcurrent
-XX:+HeapDumpOnOutOfMemoryError
-XX:+ExitOnOutOfMemoryError
-XX:-OmitStackTraceInFastThrow
-XX:ReservedCodeCacheSize=256M
-XX:PerMethodRecompilationCutoff=10000
-XX:PerBytecodeRecompilationCutoff=10000
-Djdk.attach.allowAttachSelf=true
-Djdk.nio.maxCachedBufferSize=2000000
# Reduce starvation of threads by GClocker, recommend to set about the number of cpu cores (JDK-8192647)
-XX:+UnlockDiagnosticVMOptions
-XX:GCLockerRetryAllocationCount=32
@linna-looker
Copy link

I tried to
add a flag to "-XX:+IgnoreUnrecognizedVMOptions" then the CLI container can be run for some seconds but then it failed by

io.airlift.bootstrap.ApplicationConfigurationException: Configuration errors:
1) Error: Defunct property 'hive.s3select-pushdown.enabled' (class [class HiveConfig]) cannot be configured.
2) Error: Configuration property 'hive.s3select-pushdown.enabled' was not used
2 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants