Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron based URI / Deeplinks as alternative to websocket communications #212

Closed
grctest opened this issue Sep 25, 2022 · 2 comments
Closed

Comments

@grctest
Copy link
Contributor

grctest commented Sep 25, 2022

Is your feature request related to a problem? Please describe.
Bidirectional communications between the wallet and 3rd party apps are impeded by some users environmental factors like ISP.

Ideally since we are operating locally we should be able to interact with the Beet wallet directly through URI / deep links.

Describe the solution you'd like
Rather than connect, link, broadcast, with 6 back/forth comms over websocket, the user could have a dumb broadcast-only (like UDP) interface which the user is able to interact with the Beet wallet through URI / deep link button clicks.

The user may have to copy/paste the initial identity response into the 3rd party app to store the linked account, as opposed to this occurring through socketio communications.

The 3rd party app could subscribe to the bitshares network to see the end result (if broadcast was successful), rather than get a response that it was.


The user would do the copy/paste identity setup, then could broadcast prompts to the beet wallet one way without needing a direct response from the client.

Describe alternatives you've considered
Find some alternative solution for #166

Not implement URI/Deeplinks.

Additional context

Potential for reducing attack vectors.

Potentially easier to implement as browser extension in the future.

https://www.electronjs.org/docs/latest/api/protocol

https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app

We'd use something like beet://.............. and it'd be as easy as constructing an appropriate hyperlink for the user's blockchain use case.

@grctest
Copy link
Contributor Author

grctest commented Oct 4, 2022

@grctest
Copy link
Contributor Author

grctest commented Nov 18, 2022

With #219 merged, this is implemented in the develop branch!

@grctest grctest closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant