J4 filter in backend threw error if no tags defined

J4 insert into editor correction
Allow more plugins to pickup settings in main parameters editing within JEvents
Clean up our bootstrap methods (e.g. popover) and default to Joomla version when using J4+

Author: Geraint2

component/admin/assets/js/gslframework.js

@@ -579,7 +579,8 @@ window.addEventListener('load', function () {
 		let options = {};
 
 		options.container = "#gslc";
-		options.title = filter.options[0].innerText;
+		// tags filter may be empty!
+		options.title = filter.options.length > 0 ? filter.options[0].innerText : '';
 
 		gslUIkit.tooltip(filter, options);
 

component/admin/layouts/joomla/form/field/radio/buttons.php

@@ -13,7 +13,10 @@
 use Joomla\CMS\Factory;
 
 
-if (version_compare(JVERSION, "4", "gt") && Joomla\CMS\Factory::getApplication()->getInput()->getCmd('option', '') == "com_menus")
+if (version_compare(JVERSION, "4", "gt")
+	&& (Joomla\CMS\Factory::getApplication()->getInput()->getCmd('option', '') == "com_menus"
+		|| Joomla\CMS\Factory::getApplication()->getInput()->getCmd('option', '') == "com_modules")
+	)
 {
 	include (JPATH_SITE . "/layouts/joomla/form/field/radio/buttons.php");
 	return;

component/admin/views/icalevent/tmpl/select.php

@@ -30,6 +30,7 @@
 $this->_largeDataSet = $cfg->get('largeDataSet', 0);
 $orderdir            = $input->getCmd("filter_order_Dir", 'asc');
 $order               = $input->getCmd("filter_order", 'start');
+$editor              = $input->getString('editor');
 
 $document            = Factory::getDocument();
 $document->addStyleDeclaration("body, input, select, table {font-size:11px;}
@@ -117,7 +118,7 @@
 			<tr class="row<?php echo $k; ?>">
 				<td>
 					<a href="#select"
-					   onclick="return window.parent.<?php echo $function; ?>('<?php echo $link; ?>','<?php echo addslashes(htmlspecialchars($repeat->title())); ?>' , (jQuery('#Itemid').length?jQuery('#Itemid').val():0) , <?php echo $repeat->ev_id(); ?>, <?php echo $repeat->rp_id(); ?>)"
+					   onclick="return window.parent.<?php echo $function; ?>('<?php echo $link; ?>','<?php echo addslashes(htmlspecialchars($repeat->title())); ?>' , (jQuery('#Itemid').length?jQuery('#Itemid').val():0) , <?php echo $repeat->ev_id(); ?>, <?php echo $repeat->rp_id(); ?>, '<?php echo $editor; ?>')"
 					   title="<?php echo Text::_('JEV_SELECT_EVENT'); ?>"><?php echo $row->title(); ?></a>
 				</td>
 				<td align="center">

component/admin/views/icalrepeat/tmpl/select.php

@@ -22,7 +22,7 @@
 
 $input = Factory::getApplication()->input;
 
-
+$editor = $input->getString('editor');
 $document       = Factory::getDocument();
 $document->addStyleDeclaration("body, input, select, table {font-size:11px;}
 	table.filters, table.filters tr,table.filters td {border-width:0px!important;font-size:11px;}
@@ -58,7 +58,7 @@
 			<tr class="row<?php echo $k; ?>">
 				<td width="30%">
 					<a href="#select"
-					   onclick="return window.parent.<?php echo $function; ?>('<?php echo $link; ?>','<?php echo addslashes(htmlspecialchars($repeat->title())); ?>' , (jQuery('#Itemid').length?jQuery('#Itemid').val():0) , <?php echo $repeat->ev_id(); ?>, <?php echo $repeat->rp_id(); ?>)"
+					   onclick="return window.parent.<?php echo $function; ?>('<?php echo $link; ?>','<?php echo addslashes(htmlspecialchars($repeat->title())); ?>' , (jQuery('#Itemid').length?jQuery('#Itemid').val():0) , <?php echo $repeat->ev_id(); ?>, <?php echo $repeat->rp_id(); ?>, '<?php echo $editor; ?>')"
 					   title="<?php echo Text::_('JEV_SELECT_Repeat'); ?>"><?php echo $row->title(); ?></a></td>
 				<td width="40%">
 					<?php

component/admin/views/params/tmpl/edit.php

@@ -47,7 +47,7 @@
 	//->where('enabled = 1')
 	->where('type =' . $db->quote('plugin'))
 	->where('state IN (0,1)')
-	->where('(folder="jevents" OR element="gwejson" OR element="jevent_embed")')
+	->where('(folder="jevents" OR element="gwejson" OR element="jevent_embed"  OR element="jevuser" or element="jevcreator"  or element="jevents")')
 	->order('enabled desc, ordering asc');
 
 $jevplugins = $db->setQuery($query)->loadObjectList();

component/site/assets/js/editicalJQ.js

@@ -455,6 +455,14 @@ function setEndDateWhenNotRepeating(elem){
 function forceValidDate(elem){
 	oldDate = new Date();
 	oldDate = oldDate.dateFromYMD(elem.val());
+	// if field is cleared then oldDate is empty
+	if (oldDate == "")
+	{
+		oldDate = new Date();
+		elem.val(oldDate.getYMD());
+		alert(invalidcorrected);
+		return;
+	}
 	newDate = oldDate.getYMD();
 	if (newDate!=elem.val()) {
 		elem.val(newDate);

component/site/jevents.php

@@ -325,6 +325,9 @@
 //$time_end = (float) $usec + (float) $sec;
 //echo  "JEvents component pre task = ".round($time_end - $starttime, 4)."<br/>";
 
+//HTMLHelper::_('bootstrap.popover', '.hasjevtip');
+JevHtmlBootstrap::popover('.hasjevtip' , array("trigger"=>"hover focus", "placement"=>"top", "delay"=> array( "show"=> 150, "hide"=> 150 )));
+
 // Perform the Request task
 $controller->execute($task);