You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 3, 2019. It is now read-only.
In node.js yes, much much faster. In browser I think it will be on 20-30% better.
The problem is that this PR will be very large, requires lot of resources (majority for tests) and break API.
I took a look at this to see what it would require to use secp256k1-node as an optional dependency in a way that would keep the existing API.
Started with using secp256k1-node only for signing and ran into a few issues with tests that are expecting the k value to be available. I was able to get the r and s values. I also noticed that the default signature is compact instead of DER, so signatureExport/Import was needed. Maybe the tests need to be update there for that case (tests covering an area that isn't needed).
I also took a look at using secp256k1-node for verifying only and ran into a few issues with existing tests failing, however there were only a few, and could likely be resolved.
secp256k1-node uses bindings to bitcoin/secp256k1 in node.js and elliptic (right now) in browser as fallback, available with same interface.
Since v3.0.0 was released,
bitcore-lib
could use this package for secp256k1 operations. Related: bitpay/bitcore#1285 bitpay/bitcore#1327The text was updated successfully, but these errors were encountered: