Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow add annotations/labels on private key creation/rotation #949

Open
vhsantos opened this issue Sep 8, 2022 · 2 comments
Open

Allow add annotations/labels on private key creation/rotation #949

vhsantos opened this issue Sep 8, 2022 · 2 comments
Labels
enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap

Comments

@vhsantos
Copy link

vhsantos commented Sep 8, 2022

Which component:
controller

Is your feature request related to a problem? Please describe.

Actually, the private key creation/rotation function does not allow us to include any kind of annotations/labels to it.

Which should be useful to replicate theses secrets automatically to another(s) cluster(s) using systems like "kubed/config-syncer", which check for an specific annotations on the secrets/configmaps to be replicate.

Describe the solution you'd like

private key creation/rotation should accept a list of annotations/labels from the controller configuration.

--privatekey-annotations 'kubed.appscode.com/sync: ""'
--privatekey-labels 'app.kubernetes.io/instance=production-cluster' --privatekey-labels 'app.kubernetes.io/part-of=sysadmin'

Additional context
Replicate secrets between clusters using [kubed/config-syncer](https://github.com/kubeops/config-syncer)

Note: Not sure if someone have this kind of tasks (replicate the private key between cluster) covered using another solution ?

@github-actions github-actions bot added the triage Issues/PRs that need to be reviewed label Sep 8, 2022
@agarcia-oss agarcia-oss added enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap and removed triage Issues/PRs that need to be reviewed labels Sep 15, 2022
@agarcia-oss
Copy link
Member

Hi @vhsantos this is an interesting proposal. Would you like to send a PR with the implementation?

@vhsantos
Copy link
Author

Hello @agarcia-oss ,
I would love it, but my knowledge about go language is very basic (shame on myself). :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap
Projects
None yet
Development

No branches or pull requests

2 participants