Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The private members of JS classes should not be used until ES2022 #10273

Closed
msynk opened this issue Mar 18, 2025 · 0 comments · Fixed by #10274
Closed

The private members of JS classes should not be used until ES2022 #10273

msynk opened this issue Mar 18, 2025 · 0 comments · Fixed by #10274
Assignees
@msynk
Labels
area / BlazorUI

Comments

@msynk
Copy link
Member

msynk commented Mar 18, 2025

The private members of JS classes should not be used until ES2022:

  • The new private members' syntax of JS classes has been enabled in ES2022
  • We are still using ES2019 as our TS target because of supporting the .NET 8
  • The new BitMarkdownEditor component utilizes the feature which should be updated
@msynk msynk self-assigned this Mar 18, 2025
@msynk msynk moved this to Todo in bit platform Mar 18, 2025
@msynk msynk moved this from Todo to In Progress in bit platform Mar 18, 2025
msynk added a commit to msynk/bitframework that referenced this issue Mar 18, 2025
@msynk
remove private members of JS class in BitMarkdownEditor bitfoundation…
8711a10 
…#10273
@msynk msynk mentioned this issue Mar 18, 2025
Merged
msynk added a commit that referenced this issue Mar 19, 2025
@msynk
feat(blazorui): remove private members of JS class in BitMarkdownEditor
709ac05 
#10273 (#10274)
@github-project-automation github-project-automation bot moved this from In Progress to Done in bit platform Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msynk msynk

Labels
area / BlazorUI
Projects
bit platform
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove private members of JS class in BitMarkdownEditor (#10273) msynk/bitframework
1 participant
@msynk