Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Actions undefined after changing connection #3281

Closed
2 tasks done
leonreucher opened this issue Feb 11, 2025 · 1 comment
Closed
2 tasks done

[BUG] Actions undefined after changing connection #3281

leonreucher opened this issue Feb 11, 2025 · 1 comment
Labels
BUG Something isn't working

Comments

@leonreucher
Copy link

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Users now have the option to switch the connection on which an action is executed - nice feature! But I’ve found a little issue with that:
There are modules which change the available actions and feedbacks based on selections the user made in the connection configuration. That means that some instances of the same module can have different actions. When now changing the connection in the action, all instances are shown - without checking beforehand, if the instance has the current action available.
Nothing bad can happen, its just that the action becomes undefined - but probably not 100% user friendly.

Steps To Reproduce

  1. Add two connections based on the same module
  2. Change the configuration of the modules so that other actions become available
  3. Change the connection in an action - if the action is not available in the other module, the action will become undefined.

Expected Behavior

Companion should check if the other connections of the same type support the currently selected Action. If not, the connections should not be available for user selection in the dropdown.

Environment (please complete the following information)

/

Additional context

No response

@leonreucher leonreucher added the BUG Something isn't working label Feb 11, 2025
@dnmeid
Copy link
Member

dnmeid commented Feb 12, 2025

You already describe the problem. Actions and also action options are dynamic and can vary even between instances of the same module.
The way it is implemented now is the intended one. A user will immediately see if the connection he switched to doesn't provide the action or some options. It's the responsibility of the user to deal with that. Most probably he wants to switch to exactly that connection on purpose and no has to reconfigure the connection.
Also this behavior is inline with when the configuration of a connection changes and already programmed actions become unavailable.

@dnmeid dnmeid closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants