Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Trigger Condition is delayed #2976

Closed
2 tasks done
J0h4NNes83Ere opened this issue Aug 8, 2024 · 2 comments
Closed
2 tasks done

[BUG] Trigger Condition is delayed #2976

J0h4NNes83Ere opened this issue Aug 8, 2024 · 2 comments
Labels
BUG Something isn't working

Comments

@J0h4NNes83Ere
Copy link

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

I want to trigger an overlay in OBS everytime Cam3 on my Atem mini is cut to program.
However, the trigger only activates when i cut away from Cam3.
I have tried different Events, Conditions and Actions, but everytime the trigger activates only when i cut away. The trigger is always one step delayed.
I dont believe its the Atem module, as tally / feedback works as expected. OBS set scene also works fine.
Maybe the Condition requests cached data?

Steps To Reproduce

Event: on variable change: atem:pgm1_input
Condition: Atem M/E1 Program Source: Camera 3
Action: OBS set Program Scene: "Overlay"

Expected Behavior

When Cam3 is active on PGM, the trigger should change the OBS scene

Environment (please complete the following information)

- OS: Win 10
- Browser: Firefox 127.0.2
- Companion Version: 3.3.1 (3.3.1+7001-stable-ee7c3daa)
- OBS 30.2.2
- Atem Mini Pro 9.5.1

Additional context

No response

@J0h4NNes83Ere J0h4NNes83Ere added the BUG Something isn't working label Aug 8, 2024
@Julusian
Copy link
Member

Julusian commented Aug 19, 2024

I'm not able to reproduce this. I have a pair of triggers setup as shown in the screenshot (different inputs and values for each) and the custom variable is being updated when pressing the atem buttons
image

Or if I use the On condition becoming true event, it also works

@Julusian
Copy link
Member

Oh, hang on. You're using Condition: Atem M/E1 Program Source: Camera 3.

Which means that this is expected behaviour. Feedbacks and variables are two separate systems, running their own cycles and speeds, so it is expected that they will report their updates at slightly different times to companion, causing issues such as this.

While I can understand this is confusing or annoying, changing this behaviour would require a major rearchitecture of how both feedbacks and variables work, and then updating every module to use this new architecture. This isn't impossible, but will take years (getting every module updated to the api introduced in 3.0 is still ongoing, over a year after release of 3.0) and there are other ways to do what you want, so this isn't worth the effort at this time.

You can either do it like I have shown, using just variables for both the condition and event, or swap out the event to On condition becoming true and it will work fine.

@Julusian Julusian closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants