Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Build Error #573

Open
keith-gardner opened this issue Jul 18, 2024 · 9 comments
Open

MacOS Build Error #573

keith-gardner opened this issue Jul 18, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@keith-gardner
Copy link

Describe the bug
Symbolic Links missing, as required for App Store.

Hello,

We noticed one or more issues with a recent delivery for the following app:
...
Please correct the following issues and upload a new binary to App Store Connect.

ITMS-90291: Malformed Framework - The framework bundle bdkFFI (AppName.app/Contents/Frameworks/bdkFFI.framework) must contain a symbolic link 'bdkFFI' -> 'Versions/Current/bdkFFI'. Refer to the [Anatomy of Framework Bundles](http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html) for more information.

ITMS-90291: Malformed Framework - The framework bundle bdkFFI (AppName.app/Contents/Frameworks/bdkFFI.framework) must contain a symbolic link 'Resources' -> 'Versions/Current/Resources'. Refer to the [Anatomy of Framework Bundles](http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html) for more information.

ITMS-90292: Malformed Framework - The framework bundle bdkFFI (AppName.app/Contents/Frameworks/bdkFFI.framework) 'Versions' directory must contain a symbolic link 'Current' resolving to a specific version directory. Resolved link target: '${linkTarget}'. Refer to the [Anatomy of Framework Bundles](http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html) for more information.

To Reproduce

  1. Install bdk-swift following https://github.com/bitcoindevkit/bdk-swift?tab=readme-ov-file#how-to-use
  2. Archive Mac OS with bdk-swift and submit to app store

Expected behavior
Expecting no build errors.

Build environment

  • BDK tag/commit: 0.31.1
  • OS+version: Sonoma 14.5
@keith-gardner keith-gardner added the bug Something isn't working label Jul 18, 2024
@reez
Copy link
Collaborator

reez commented Jul 18, 2024

Thanks @keith-gardner! Can you let me know what Xcode version you're using as well?

@keith-gardner
Copy link
Author

Thanks @keith-gardner! Can you let me know what Xcode version you're using as well?

Version 15.4 (15F31d)

@keith-gardner
Copy link
Author

Will be in Nashville next week, happy to go through in person

@reez
Copy link
Collaborator

reez commented Jul 18, 2024

Great ya lets connect in person for sure!

BDK 1.0 beta is right around the corner too so if you all have been playing around with any of our bdk-ffi alpha releases and have any questions or thoughts on 1.0 I'd love to chat on that as needed as well-

@keith-gardner
Copy link
Author

Want to join @BrantaOps on Telegram, like our last message and I'll text you? Will delete this comment after

Also have Signal 👍

@reez
Copy link
Collaborator

reez commented Jul 19, 2024

Want to join @BrantaOps on Telegram, like our last message and I'll text you? Will delete this comment after

Also have Signal 👍

I dont have telegram, so we will have to connect either on the BDK Discord or on Signal

@keith-gardner
Copy link
Author

Solid, posted in Development channel

@reez
Copy link
Collaborator

reez commented Jul 19, 2024

Solid, posted in Development channel

Sweet, I see ya, will DM about nashville-

@reez
Copy link
Collaborator

reez commented Aug 5, 2024

Great meeting you!

Xcode 15.3+ had breaking changes for a lot of projects firebase/firebase-ios-sdk#12587, ours included #463

We made a fix for it #466 , via experimentation since there was no official documentation, might be what we have to do with this one too.

If you'd like to help test/fix:

  • Test with Xcode 15.2 to see if that works (it was the last version that worked before breaking changes from Xcode, it would give us an additional data point, sadly I've had to keep Xcode 15.2 on my machine just due to having to test all the pre/post breaking change things)
  • Let me know what you're specs for your macOS app is (min OS version, etc) and then I can reproduce on my end, because archiving was an additional fix previously (pre-BDK1.0) Update bdk-swift framework info.plist for xcode 15.3 reqs #466 (comment) in addition to just getting things to build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants