Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packages from registry instead of github #5

Open
emanuelb opened this issue Apr 19, 2021 · 1 comment
Open

Use packages from registry instead of github #5

emanuelb opened this issue Apr 19, 2021 · 1 comment

Comments

@emanuelb
Copy link

From packages.json:

    "electrum-client": "https://github.com/BlueWallet/rn-electrum-client",
    "react-native-qrcode-scanner": "https://github.com/moaazsidat/react-native-qrcode-scanner",

it use git repo instead of yarn/npm registry, which require additional git dep to compile the app & repo can be removed/relocated/changed in a way that will break the build, using packages is better.

The react-native-qrcode-scanner can be used as it's available in yarn/npm registries.
https://yarnpkg.com/package/react-native-qrcode-scanner
https://www.npmjs.com/package/react-native-qrcode-scanner

regarding rn-electrum-client it's not available yet, opened issue about it at: BlueWallet/rn-electrum-client#7

@Cobra-Bitcoin
Copy link
Contributor

Thank you!

I'll switch over to using packages where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants