Frontend

[alexchorman]

Hey @Cobra-Bitcoin. I would like to let you know that I am starting to work on the desktop application. Would like to keep our conversations here? Let me know if you want to move our conversation in some other place.

[Cobra-Bitcoin]

@alexcherman Hey, GitHub is the best place. Let me know if you have any issues with the code and setting up the project and I can try my best to help.

How familiar are you with Vue.js? You might have to move around some of the code into different screens, but basically all the code is implemented already and it just needs the frontend to be designed into it.

[alexchorman]

Thanks. I did one project in Vue.js and didn't have any problems with it, besides code is implemented already. I'll let you know if I need any help

[alexchorman]

@Cobra-Bitcoin Could you send me list with all of the languages for app?

[Cobra-Bitcoin]

So far the following languages:

• English
• Français
• Español
• Japanese
• Catalan

The list can be found here: https://github.com/bitcoin-dot-org/Bitcoin-Wallet/tree/master/src/lang

[alexchorman]

Thanks @Cobra-Bitcoin. Could you also send me this link?

[Cobra-Bitcoin]

@alexcherman https://www.blockchain.com/btc/tx/{the-transaction-id}

I will have to re-arrange the code to get it to populate some of those fields properly, for example, right now we are showing block height instead of date, so I need to write the code to get the timestamp from the transaction and store that in the database, but as long as the design is in place, I can do that stuff myself, it just needs to look like the design and I will handle updating the logic in the backend when it's all complete.

[alexchorman]

Hey @Cobra-Bitcoin. Are you ok if I use vue-styled-components for this project? There are lots of elements I want to reuse.

[Cobra-Bitcoin]

@alexcherman Yeah, that's fine.

[alexchorman]

@Cobra-Bitcoin Thanks. What about copy in the design? Could you check it? You already have some translations in the project but it differs from what you have in the design. Is it ok?

[Cobra-Bitcoin]

@alexcherman You mean the "Copy" text in the receive tab? It's fine if you get rid of that, and change it to a button like in the design. In general, the more closer it looks to the design, the better, even if you have to get rid of stuff or hide things.

[Cobra-Bitcoin]

@alexcherman Also, let me know the branch you're working on, so I can keep track of the changes and follow along.

I think the text throughout the app doesn't really matter for now, as it can be replaced any time, even if you have to use lorem ipsum text, or keep the current text in parts.

[alexchorman]

@Cobra-Bitcoin Opened pull request. You can follow the progress here: #11

[Cobra-Bitcoin]

@alexcherman Awesome, looks good.

[alexchorman]

Great, thanks. I'm glad that you like it.

[Cobra-Bitcoin]

@alexcherman Just a heads up, but don't worry about the titlebar needing to be darkened on Windows, I plan on using this library (https://github.com/Treverix/custom-electron-titlebar) when the design is done and adding it myself.

[alexchorman]

@Cobra-Bitcoin Ok, sure

[alexchorman]

@Cobra-Bitcoin Is there any possibility to display data like this:

or should I use placeholder data instead?

[Cobra-Bitcoin]

@alexcherman Just use placeholder, we have some of the data but it's not finalized yet, so there's no point using it.

[alexchorman]

Hey @Cobra-Bitcoin. I think I finished frontend part. Could you check it please? Let me know if you want me to improve something.

[Cobra-Bitcoin]

@alexcherman Hey, I just checked and almost everything is fine, except the restore wallet screen looks broken: https://i.imgur.com/4cUSleh.png. There's too much space inbetween the textfields and the scroll bar shouldn't be appearing. Other than that, it looks finished.

[alexchorman]

Hi @Cobra-Bitcoin. Thanks for the comment. I'll fix it and let you know.

[alexchorman]

Hey @Cobra-Bitcoin, I suggest to increase the width of the window. Layout is broken because on windows you have scroll on the right side and it takes up the space that was intended for the content. On my mac I don't have the scroll and layout looks ok. Could you change it here:

Bitcoin-Wallet/src/background.ts

Line 21 in 478a834

win = new BrowserWindow({ width: 800, height: 600, webPreferences: {

[Cobra-Bitcoin]

@alexcherman No problem, I'll merge your frontend work into the main repo and then mess around with the width to get it looking nice on all platforms (I still need to test on Linux too).

Thanks a lot for all your work on this, it looks really amazing, already one of the best looking desktop Bitcoin wallets out there, and feels very nice and user friendly. 👍

[alexchorman]

@Cobra-Bitcoin Great, thanks. Let me know if you need any help or you want me to improve something.

[Cobra-Bitcoin]

@alexcherman I pushed some changes to master to fix the issue with the recover screen, somehow I managed to get it working without needing to change the width, but I'm not sure if it would work on different screen sizes. Can you check if it still looks OK for you?

I also changed the way the lists are rendered to match more closely with the design.

[alexchorman]

Hey @Cobra-Bitcoin. Yes, of course. I'll check it.

[alexchorman]

Hey @Cobra-Bitcoin, I checked it on my mackbook and looks ok. Why do you need to check it on different screen sizes? I thought that the wallet window would always have a fixed width.

[Cobra-Bitcoin]

Sorry, I meant different operating systems, I got confused. The various operating systems seem to render the window in different ways, which causes different thresholds for when the scroll bar is shown, so that broke things. It seems fine now though if it looks good for you on MacOS and for me on Windows.