Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Simulation Time #81

Open
carlaKC opened this issue Aug 28, 2023 · 1 comment
Open

Feature: Simulation Time #81

carlaKC opened this issue Aug 28, 2023 · 1 comment
Assignees
Milestone

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Aug 28, 2023

Some use cases may want to use simulation time rather than seconds. Steps to complete:

  1. Abstract time usage to trait (implemented by system time)
  2. Add implementation time trait implementation (this possibly exists already - do some googling)
  3. Update user config to be able to opt into sim time (high level parameter / config interval_secs -> more generic interval?)
@carlaKC
Copy link
Contributor Author

carlaKC commented Feb 12, 2024

As a first step for this, we can pull out the time based functionality in sim-ln into a Clock trait.

There's some debate as to whether simulation time will work with real nodes, because we can only go as fast as the underlying node can process payments. That said, with the addition of #165 we'd be interested in simulation time (as the simulated nodes are incredibly cheap to run) so I'd like to start down this path.

This will probably need some forward thinking as to what simulated time we're going to use to minimize refactoring. I took a brief look at game_time which looked promising but haven't done a deep dive.

@carlaKC carlaKC self-assigned this Mar 12, 2024
@carlaKC carlaKC added this to the V3 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant