Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize URL parameter handling in urlBuilders #328

Open
coderabbitai bot opened this issue Dec 10, 2024 · 0 comments
Open

Standardize URL parameter handling in urlBuilders #328

coderabbitai bot opened this issue Dec 10, 2024 · 0 comments
Assignees
@sheriffjimoh
Labels
difficulty:easy Issues that are easy to solve. OSS Open Source Issue

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

A potential inconsistency was identified in the handling of the chatbot parameter within the urlBuilders methods.

Details:

  • In threadUrl, chatbot uses toSlug(chatbot)
  • In userChatbotUrl, chatbot uses chatbot.toLowerCase()

This discrepancy could lead to URL mismatches. It is recommended to standardize the approach using toSlug for consistency.

Refer to PR #316 and the comment: #316 (comment)

Requested by @AndlerRL.
@AndlerRL AndlerRL added difficulty:easy Issues that are easy to solve. OSS Open Source Issue and removed difficulty labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheriffjimoh sheriffjimoh

Labels
difficulty:easy Issues that are easy to solve. OSS Open Source Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndlerRL @sheriffjimoh