Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Update tailwind.config Colour System #232

Open
AndlerRL opened this issue Jun 24, 2024 · 0 comments
Open

Review and Update tailwind.config Colour System #232

AndlerRL opened this issue Jun 24, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed ui/ux

Comments

@AndlerRL
Copy link
Contributor

By default, when shadcn/ui is installed, it puts default CSS variables for the colours with HSL values. These default variables however has repeated values that doesn't match with the colour context. i.e.: We set the tertiary CSS Variable but instead must be the accent colour, and the accent colour is used outside of his context and some components already has it in use...

There is however a blocker in here, which is to finish the Masterbots' Design System on Figma, and to declare these colour hierarchy. also for an attempt to remove duplicated tailwindCSS classes which on the long run would be beneficial for the compilation time when the app goes bigger.

After getting the Design System:

Compare the colours values and names and set them as HSLA (no HEX nor RGBA). Prior that, Check the HEX and RGBA values on components to see if they are already assigned.

@AndlerRL AndlerRL added enhancement New feature or request help wanted Extra attention is needed ui/ux labels Jun 24, 2024
@AndlerRL AndlerRL changed the title Review and Update tailwind.config Colour Sysstem Review and Update tailwind.config Colour System Jun 24, 2024
@AndlerRL AndlerRL mentioned this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ui/ux
Projects
None yet
Development

No branches or pull requests

1 participant