daemon API: provide command to inform on trading and mining fees when taking an offer

[pmartincalvo]

In bisq GUI, when you select an offer from the book to take it, you land on a confirmation screen. This screen, among other things, informs you about the trading and mining fees you will incur if you finally confirm and take the offer.

In the bisq daemon API there is no way to obtain this trading and mining fee before taking an offer. The response OfferInfo returned by methods GetOffers and GetOffer does not provide any information on the trading fees, mining fees and deposit requirements.

I believe that a command that provides this info is key for the bisq daemon. Otherwise, users blindly jump into trades unaware of these important details. This could be done by either creating a new command entirely or expanding the GetOffer method to include this information.

[ripcurlx]

@ghubstan ☝️

[ghubstan]

@pmartincalvo This does need to be fixed. What would be your preference?

(a) Adding a second table of CLI output to the getoffer command, showing the trading and mining fee info? Adding this type of info to the getoffer method results would make it inconsistent with the details you see when viewing offer details in the GUI -- where no fee details are displayed.

(b) Adding a --dryrun=true param to the existing takeoffer command? This would return the fee details instead of actually taking the offer.

(c) Adding a new method/command to the API. takeoffer-dryrun? takeoffer-fees? I'm sure there's a better method name for this.

There may be other ways to implement this.

I prefer option (b), then option (c).

Option (b) would be analogous to clicking the TAKE OFFER button in the GUI and then looking at the Fund your trade pop-up. This pop-up shows security deposit amt., trade amt., trading fee, total mining fees. You do not see these details when you click an offer's details link.

[pmartincalvo]

@ghubstan is there a PR or Issue where we can keep a track of the status of this? Thanks.

[ghubstan]

I will create a PR for this work -- probably next week.

[ghubstan]

I will reference this discussion in it.

[ghubstan]

I still need to finish my current task before I begin work on this, but it is next on my plate.

[pmartincalvo]

Great :)

[ghubstan]

Other team members have decided to significantly reduce the frequency of Bisq v1 updates (new releases are bug-fixes only), to focus on Bisq v2.

Work on any new Bisq v1 API methods is on indefinite hold.

[pmartincalvo]

:(