Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Repositories Architecture #40

Open
rodvar opened this issue Nov 13, 2024 · 2 comments
Open

Shared Repositories Architecture #40

rodvar opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@rodvar
Copy link
Collaborator

rodvar commented Nov 13, 2024

This issue goals are

  • update README docs explaining this concept and how are we using it to cater for the 3 apps.
  • Create the definitions and abstractions for what a repository to make things easier for further development
  • provide an example of a repository (e.g. SettingsRepository) , could be just in-memory for now. Could be for the AppSettings model.
  • provide an example of usage, that extends the settings saved in the androidNode (so the model used has the shared settings + specific ones)
  • use koin for DI

after this gets implemented it should be easier to add share repositories for the different shared UI needs. Those repositories data will be fed by the different services (more on this on the README update)

@rodvar rodvar self-assigned this Nov 13, 2024
@rodvar
Copy link
Collaborator Author

rodvar commented Nov 13, 2024

I'm thinking we might get away for all the repositories with a couple of abstractions definitions and 1 or 2 implementations with generics cause after all the repositories will do always the same thing just need to know which model parameter are they dealing with.

Those implementations could get a persistence store via parameter (optional) and if they have it, they can also persist stuff.

then we just define the DI repository (dataRepository) which all the single repositories per POKO .
these repositories use kotlin mp StateFlow to implement observer/observable and voila!

@rodvar
Copy link
Collaborator Author

rodvar commented Nov 14, 2024

the above PR addresses most but not all of the stuff, I'll do one more PR and we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant