We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch @birdwingo/[email protected] for the project I'm working on.
@birdwingo/[email protected]
The problem is only on android platform. The story screen doesn't cover the whole screen with status bar and navigation
So it looks like this
After my fix it's like
Please create a small fix to solve this problem. Thanks!
Here is the diff that solved my problem:
diff --git a/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx b/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx index 873c3b9..56dce43 100644 --- a/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx +++ b/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx @@ -453,7 +453,7 @@ const StoryModal = forwardRef<StoryModalPublicMethods, StoryModalProps>( ( { ); - <Modal visible={visible} transparent animationType="none" testID="storyRNModal" onRequestClose={onClose}> + <Modal visible={visible} statusBarTranslucent transparent animationType="none" testID="storyRNModal" onRequestClose={onClose}> diff --git a/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts b/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts index 4ea5850..d36284d 100644 --- a/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts +++ b/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts -export const { width: WIDTH, height: HEIGHT } = Dimensions.get( 'window' ); +export const { width: WIDTH, height: HEIGHT } = Dimensions.get( 'screen' );
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered:
The ts is throwing error for import in the following file - components/Image/index.tsx
import { StoryItemProps } from '~/core/dto/instagramStoriesDTO'; => import { StoryItemProps } from '../../core/dto/instagramStoriesDTO';
could you fix it also please
Sorry, something went wrong.
LukasFridmansky
Successfully merging a pull request may close this issue.
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
@birdwingo/[email protected]
for the project I'm working on.The problem is only on android platform. The story screen doesn't cover the whole screen with status bar and navigation
So it looks like this
After my fix it's like
Please create a small fix to solve this problem. Thanks!
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: