Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check the build works on macOS host with the latest CMake v3.31.4 #130

Open
birdofpreyru opened this issue Jan 24, 2025 · 5 comments
Labels
P2 Important issue.

Comments

@birdofpreyru
Copy link
Owner

See: #29 (comment)

@birdofpreyru birdofpreyru added the P2 Important issue. label Jan 24, 2025
@sambouchard-newforma
Copy link

sambouchard-newforma commented Jan 29, 2025

With the new CMake version installed via Homebrew, the following symlink :
$ sudo ln -s $(which cmake) /usr/local/bin/cmake
Seems to not be the only one we need to do. With that symlink, the command cmake --version returns :

cmake version 3.31.5

CMake suite maintained and supported by Kitware (kitware.com/cmake).

but the command /usr/local/bin/cmake --version returns :

CMake Error: Could not find CMAKE_ROOT !!!
CMake has most likely not been installed correctly.
Modules directory not found in
/usr/local/share/cmake
cmake version 3.31.5

Which is the same error I get when trying to build my app using with react-native-server

I created a symlink with sudo ln -s /opt/homebrew/Cellar/cmake/3.31.5/share/cmake /usr/local/share/cmake and now the build doesn't throw an error anymore

@sambouchard-newforma
Copy link

sambouchard-newforma commented Jan 29, 2025

Build times seem to have increased with cMake 3.31.5. It used to take ~140s to build the library with cMake 3.30.x and now it takes sometimes ~170s with cMake 3.31.5

@birdofpreyru
Copy link
Owner Author

With the new CMake version installed via Homebrew, the following symlink:

I don't know, but it reads to me like you just messed up CMake installation on your particular machine, so that now which cmake points to the location of an older, removed or broken installation. Perhaps, nothing wrong with this library setup.

_Build times seem to have increased with cMake 3.31.5. It used to take ~140s to build the library with cMake 3.30.x and now it takes sometimes ~170s with cMake 3.31.5

🤷‍♂

@sambouchard-newforma
Copy link

sambouchard-newforma commented Jan 29, 2025

This is following a clean install of cMake (delete all other version and trace of cMake) and installing it with brew install cmake

@birdofpreyru
Copy link
Owner Author

birdofpreyru commented Feb 2, 2025

Hmm... I run into the same problem after upgrading from CMake 3.30 to the latest 3.31.5 on my macOS machine, installed via Homebrew 😓 Your workaround, @sambouchard-newforma , with sym-linking share/cmake folder, works fine for me. I have no idea what is (if there is) a proper / better way to deal with it, I'll just add the info to README, with a reference to this very issue; and I'll keep this issue open, hoping that somebody with more knowledge comments on it, or the issue magically goes away with future cmake versions 🤷‍♂

birdofpreyru pushed a commit that referenced this issue Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issue.
Projects
None yet
Development

No branches or pull requests

2 participants