Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmespath cleanup and followup #841

Open
colleenXu opened this issue Jul 30, 2024 · 0 comments
Open

Jmespath cleanup and followup #841

colleenXu opened this issue Jul 30, 2024 · 0 comments
Labels
debt Issue represents some technical debt jq / jmespath needs discussion

Comments

@colleenXu
Copy link
Collaborator

colleenXu commented Jul 30, 2024

There's a pile of jmespath-related issues to follow-up on and potentially close/cleanup:

A. Use filter, replace list_filter -> jmespath. Chunlei et al have been asking about this (3/28), so they can then remove outdated functionality

Notes

  • Start w/ BioThings API queries -> try adjusting them
  • note when yaml comments are old, but don't need to do all the work to update them
  • Using filter, can we access the operations w/o action_type? See the yaml comment on MISSING

B. For all jmespath in MyChem, use modified always_list parameter. See if it fixes buggy behavior (BioThings issue 323). MyChem was updated with this support May 9 (Translator Slack link).

  • Also implement: there's a use case for MyGene (summary here). Look for other cases where this is needed?

C. Try diff syntax (my thoughts) for these cases (MyChem, MyVariant) - trying to get publication info in reverse direction. Remember the parts of the response I want to keep (BioThings issue 324, 325)

D. drugcentral.bioactivity.action_type review

Notes: can assign BioThings issue to me to review, initial test to see if BioThings feature is working, then close BioThings issue. Then track actually implementing/using this feature in another issue like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Issue represents some technical debt jq / jmespath needs discussion
Projects
None yet
Development

No branches or pull requests

1 participant