ReleaseManager does not read "move" operation from jsondiff results

[erikyao]

1. Problem

Involved method: analyze_diff

Code example:

from biothings.utils.jsondiff import make as jsondiff

old_mapping = {
  "clinvar": {
    "properties": {
      "gene": {
        "properties": {
          #############
          # OLD FIELD #
          #############
          "gene_id": {
            "type": "long"
          }
        }
      },
    }
  }
}

new_mapping = {
  "clinvar": {
    "properties": {
      "gene": {
        "properties": {
          ###############
          # NEW FIELD 1 #
          ###############
          "id": {
            "type": "long"
          },
          ###############
          # NEW FIELD 2 #
          ###############
          "new_id": {
            "type": "long"
          }
        }
      },
    }
  },
}

diff_result = jsondiff(old_mapping, new_mapping)
print(diff_result)

Output:

[{'op': 'move',
  'path': '/clinvar/properties/gene/properties/id',
  'from': '/clinvar/properties/gene/properties/gene_id'},
 {'op': 'add',
  'path': '/clinvar/properties/gene/properties/new_id',
  'value': {'type': 'long'}}]

However, 'op': 'move' is not handled in analyze_diff. It's better to split move(path="id", from="gene_id") => add(path="id") + remove(path="gene_id") when generating the release notes.

2. Reference

Accoding to rfc6902, add, remove, replace, move are all valid operations.

[erikyao]

To be fixed along with biothings/myvariant.info#103

[erikyao]

Now the involved code are at https://github.com/biothings/biothings.api/blob/master/biothings/hub/datarelease/releasenote.py#L212