Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(biome_diagnostics): fix JetBrains relative file URLs should be clickable when given line and column numbers #4875

Closed
wants to merge 10 commits into from
Closed

fix(biome_diagnostics): fix JetBrains relative file URLs should be clickable when given line and column numbers #4875

wants to merge 10 commits into from

Conversation

Andrew-Chen-Wang
Copy link

Summary

Fixes #4874

Jetbrains IDEs for relative file paths aren't clickable in diagnostics output. In webstorm, it requires prepending at (notice the whitespaces)

This does not fix the case where no line numbers and column numbers are displayed for relative paths. See test cases

Test Plan

Screenshot 2025-01-11 at 7 55 24 AM

Test cases display:

  • the environment variable
  • a test where my relative path in my app was caught with a lint error but nothing was highlighted
  • this PR only resolves relative file paths with column numbers and/or line numbers
  • separate variant with only a line number
  • test case that the absolute path case does work, regardless if there's a line number or not
Screenshot 2025-01-11 at 7 57 24 AM - This is in PyCharm. Some devs develop across IDEs, and here it does work

tunamaguro and others added 10 commits January 3, 2025 13:34
@tunamaguro @ematipico
feat(linter): add noNoninteractiveElementInteractions rule (biomejs…
a658a29 
…#4358)

Co-authored-by: Emanuele Stoppa <[email protected]>
@renovate
chore(deps): update rust crate insta to 1.42.0 (biomejs#4839)
868f9a1 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update pnpm to v9.15.3 (biomejs#4838)
c44ba00 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @types/node to v20.17.12 (biomejs#4837)
b8b1530 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @typescript-eslint/eslint-plugin to v8…
68f7c14 
….19.1 (biomejs#4806)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@bushuai
fix(formatter): refine the logic for identifying comments on the last…
eedb22e 
… attribute in JSX (biomejs#4835)t
@lucasweng
fix(useSortedClasses): should suggest code fixes that match the JSX q…
4007147 
…uote style of the formatter (biomejs#4857)
@mdm317
fix(js_formatter): updated the is_test_call_expression function to ma…
c93dc5f 
…tch prettier (biomejs#4811)
@bushuai
chore: improve task comments for creating new lint rules (biomejs#4866)
1a4e36f
@Andrew-Chen-Wang
fix: JetBrains relative file URLs should be clickable when given line…
388acff 
… and column numbers
@github-actions github-actions bot added A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Jan 11, 2025
@Andrew-Chen-Wang Andrew-Chen-Wang changed the title fix: JetBrains relative file URLs should be clickable when given line and column numbers fix(biome_diagnostics): JetBrains relative file URLs should be clickable when given line and column numbers Jan 11, 2025
@Andrew-Chen-Wang Andrew-Chen-Wang changed the title fix(biome_diagnostics): JetBrains relative file URLs should be clickable when given line and column numbers fix(biome_diagnostics): fix JetBrains relative file URLs should be clickable when given line and column numbers Jan 11, 2025
@Andrew-Chen-Wang

This comment was marked as off-topic.

Sign in to view
ematipico
ematipico reviewed Jan 11, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you:

  • add a link that documents the value of the terminal emulator (or that explains why the links should be emitted like this)
  • send the PR against the next branch

@Andrew-Chen-Wang Andrew-Chen-Wang changed the base branch from main to next January 11, 2025 14:11
@Andrew-Chen-Wang
Copy link
Author

Andrew-Chen-Wang commented Jan 11, 2025 •
edited
Loading

@ematipico thanks for the review. I added the requested link in the new PR: #4876

made a new PR because I don't really have the time to rebase:/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 make file in biome output clickable for webstorm/jetbrains/intellij
6 participants
@Andrew-Chen-Wang @ematipico @tunamaguro @bushuai @lucasweng @mdm317