Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Settings in the ProjectLayout #4849

Open
arendjr opened this issue Jan 7, 2025 · 2 comments
Open

Include Settings in the ProjectLayout #4849

arendjr opened this issue Jan 7, 2025 · 2 comments
Labels
A-Project Area: project

Comments

@arendjr
Copy link
Contributor

arendjr commented Jan 7, 2025

#4846 introduced the ProjectLayout, but it only includes for NodeJsPackage for now. I want to include Settings there as well, so that we can store settings from nested biome.json files too.

One other thing we'll need to do is to let nested biome.json that don't specify an extends field, to extend from parent configs transparently. If desired, we can also split that into a separate issue/PR.

@arendjr arendjr added the A-Project Area: project label Jan 7, 2025
@ematipico
Copy link
Member

to extend from parent configs transparently

What's the rationale? Are there specific requirements or will it be the default behaviour for all biome projects?

@arendjr
Copy link
Contributor Author

arendjr commented Jan 8, 2025

I think it should be the default behaviour indeed. I think it aligns most with user expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project
Projects
None yet
Development

No branches or pull requests

2 participants