🐛 Imports are not sorted

[informeti]

VS Code version

1.92.2

Extension version

2.3.0

Biome version

1.8.3

Operating system

• Windows
• macOS
• Linux

Description

Formatting (on save, or manually) doesn't sort imports.
The extension also doesn't indicate any warning or error regarding import order.

However, biome check reports errors:

biome check main.ts
main.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Import statements could be sorted:
  
     1    │ - import·type·{·Construct·}·from·"constructs";
     2    │ - import·{·App,·TerraformStack·}·from·"cdktf";
     3    │ - import·{·AzurermProvider·}·from·"@cdktf/provider-azurerm/lib/provider";
     4    │ - import·{·StorageBackend·}·from·"./src/storage-backend";
     5    │ - import·{·resourceGroup·}·from·"@cdktf/provider-azurerm";
        1 │ + import·{·resourceGroup·}·from·"@cdktf/provider-azurerm";
        2 │ + import·{·AzurermProvider·}·from·"@cdktf/provider-azurerm/lib/provider";
        3 │ + import·{·App,·TerraformStack·}·from·"cdktf";
        4 │ + import·type·{·Construct·}·from·"constructs";
        5 │ + import·{·StorageBackend·}·from·"./src/storage-backend";

Steps to reproduce

Write a TypeScript file with wrongly sorted imports.

Expected behavior

The extension should show a warning or error when the imports are not sorted as expected, and should offer a quickfix.

When formatting the document (manually or on save), the imports should be sorted.

Does this issue occur when using the CLI directly?

No

Link to a minimal reproduction

No response

Logs

No response

[nhedger]

Did you follow https://biomejs.dev/analyzer/import-sorting/#import-sorting-via-vscode-extension ?

[ematipico]

The extension should show a warning or error when the imports are not sorted as expected, and should offer a quickfix.

This is by design. Import sorting is meant to work very much like formatting: you configure your IDE/editor to run it on save, and then you can use the CLI to enforce it wherever you want

[informeti]

Did you follow https://biomejs.dev/analyzer/import-sorting/#import-sorting-via-vscode-extension ?

Thank you! While it doesn't work as documented, it works as follows (i.e. without .biome):

"editor.codeActionsOnSave": {
	"source.organizeImports": "explicit"
}

[jackTabsCode]

I'm still not able to get this working on 1.9.0 or any of the 1.8.4 nightlys. The imports will sort with the CLI, but not the extension. Can someone send me their VSCode configuration to allow this?

[shayneo]

After upgrading to 1.9.0

"source.organizeImports": "explicit"

works for me.

"source.organizeImports.biome": "explicit"

does not.

my full codeActionsOnSave now is set to:

"editor.codeActionsOnSave": {
    "source.organizeImports": "explicit",
    "source.organizeImports.biome": "explicit",
    "source.fixAll.biome": "explicit",
    "quickfix.biome": "explicit"
}

as a workaround

[ematipico]

This is a regression. It should work with the .biome postfix.

[shayneo]

After upgrading to 1.9.0

"source.organizeImports": "explicit"

works for me.

"source.organizeImports.biome": "explicit"

does not.

my full codeActionsOnSave now is set to:

"editor.codeActionsOnSave": {
    "source.organizeImports": "explicit",
    "source.organizeImports.biome": "explicit",
    "source.fixAll.biome": "explicit",
    "quickfix.biome": "explicit"
}

as a workaround

correction - this isn't actually working. It's using the editor's default sort order when I do that.

[jackTabsCode]

It's using the editor's default sort order when I do that.

Right, this is supplied by the Typescript language server. Biome's import sorting is different from Typescript's (for whatever reason), so while this will sort your imports in some way, biome check will fail-and the extension refuses to organize/sort imports right now.

[ematipico]

I am sure the cause of the regression is #3731

[malininss]

I use the 1.9 version.
"source.organizeImports.biome": "explicit" still doesn't work for me.
"source.organizeImports": "explicit" works fine

[alimehasin]

Did you follow https://biomejs.dev/analyzer/import-sorting/#import-sorting-via-vscode-extension ?

We did, still formatting via the extension fails while formatting in the cli work

[ematipico]

Duplicate of #3879

It will be fixed in the next patch

[ck-euan]

The extension should show a warning or error when the imports are not sorted as expected, and should offer a quickfix.

This is by design. Import sorting is meant to work very much like formatting: you configure your IDE/editor to run it on save, and then you can use the CLI to enforce it wherever you want

@ematipico So is there no way to automate it?
I just reenabled import sorting for my project and now have hundreds of files to go through, do I have to manually save each one? 😅

[jackTabsCode]

@ck-euan You'd run biome check --write

[ck-euan]

@jackTabsCode For me imports never sort with the CLI I just get the error "Import statements could be sorted"

[ematipico]

@jackTabsCode For me imports never sort with the CLI I just get the error "Import statements could be sorted"

You need to use --fix to actually apply the sorting